-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal to separate Nullable backend into DataFrames2 #1154
Comments
That sounds fine to me but I would wait until DataArrays works on Julia 0.6. That's really the prerequisite before we can consider the old DataFrames framework as viable for at least one more release. |
Also, in practical terms, I guess it would be better to rename this repo to DataFrames2 so that we don't lose open issues/PR, which contain lots of useful discussions and still valid points. Then we can create a new DataFrames package from the |
This seems like a more-workable approach. |
I'd recommend the other way around, leave this repo in place since the majority of the issues are w.r.t. the DataArrays backend. Can switch around the github default branch in the short term, and (optionally) roll back master once there's a separate new repo for the NullableArrays backend? |
I don't really like this idea since in the end we'll have two projects with useful history: this one, plus DataFrames2 and issues/PR filed during the transition. The way forward is DataFrames2, so it should retain the history; DataFrames 0.8 is the dead-end and we won't care about it in a few months. |
I don't like the idea that the long-term name will be |
Uncertainty about this is why this issue was filed. Isn't it still unclear whether the implementation that's on master is going to be the long term usable solution? This is taking time and the original February plan is nearly here, without the picture on the ground having changed much. |
Yes, of course my idea would be to deprecate DataFrames at some point, and later replace it with DataFrames2.
Even if the implementation based on |
I'm strongly in favor of this proposal. In terms of naming, what about naming the new version |
I'd be fine with a name like DataTable. If we did something like that then perhaps we wouldn't need to merge it back with DataFrames at all; the |
Glad to see there's support for this. Action items (which as I write them are snowballing) are as follows:
Longer term items:
Seems simple enough... maybe?! 😵 |
This issue seems to have served its purpose, so I'm going to go ahead and close it. Thanks everyone for your help and feedback! |
After much thought and conferring with others, I'd like to formally propose that we separate the current master branch of DataFrames into a separate package, tentatively called DataFrames2.
Advantages:
Nullable
may change nontrivially (see [WIP] Nullable Redesign JuliaLang/Juleps#21)Nullable
-based backend is more difficult to work with at the moment (see Working with Nullable DataFrames #1148)Nullable
-backend version, the current version will continue to be more actively maintainedrelease-0.8
branchDisadvantages:
using DataFrames2
is kind of unfortunate as a long-term name unless we re-merge the packages at some pointFixing DataArrays is definitely not trivial, but I think overall this is the best course of action for both the developers and the users. I'd love to hear your thoughts, including further advantages or disadvantages not covered here.
The text was updated successfully, but these errors were encountered: