Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace replace with a comprehension #1713

Open
bkamins opened this issue Feb 5, 2019 · 3 comments
Open

Replace replace with a comprehension #1713

bkamins opened this issue Feb 5, 2019 · 3 comments
Labels
non-breaking The proposed change is not breaking performance
Milestone
1.x

Comments

@bkamins
Copy link
Member

bkamins commented Feb 5, 2019

See #1709 (comment).
This should be changed when JuliaLang/julia#30485 is fixed.
@bkamins bkamins added this to the 1.0 milestone Feb 5, 2019
@bkamins bkamins mentioned this issue Feb 5, 2019
Merged
@bkamins
Copy link
Member Author

bkamins commented Sep 2, 2019

@nalimilan Given JuliaLang/julia#30485 maybe we should drop 1.0 milestone here?

@nalimilan
Copy link
Member

Let's see whether we can make progress on that issue. I've pinged Jameson.

@bkamins bkamins removed this from the 1.0 milestone Feb 12, 2020
@bkamins bkamins added non-breaking The proposed change is not breaking performance labels Feb 12, 2020
@bkamins
Copy link
Member Author

bkamins commented Dec 4, 2022

@nalimilan now this can be fixed but it would produce the following union in inference:

Union{Vector{Missing}, Vector{Union{Missing, Int}}, Vector{Int}}

(but indeed if Vector{Int} is produced, which is most common, it would be faster)

Are we OK with this and make the change?

@bkamins bkamins added this to the 1.5 milestone Dec 4, 2022
@bkamins bkamins modified the milestones: 1.5, 1.6 Feb 5, 2023
@bkamins bkamins modified the milestones: 1.6, 1.7 Jul 10, 2023
@bkamins bkamins modified the milestones: 1.7, 1.x Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
non-breaking The proposed change is not breaking performance
Projects
None yet
Milestone
1.x
Development

No branches or pull requests
2 participants
@nalimilan @bkamins