-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What to do about order() #176
Comments
I really dislike the name |
I think we're on the same page. Okay to have |
Definitely. I would like |
Order strikes me as an extremely overloaded term. I have to confess that I don't really get the objection to sortperm. Is the issue its new behavior or the name itself? |
My concern is twofold:
|
I don't think that sortperm is actually from Matlab (@ViralBShah, @JeffBezanson?), I think we just chose the name at some point and it stuck – previously for sorting and returning a permutation. In Matlab you just use the sort function with two arguments for that and do |
I think Perhaps the |
We should use the same name in base and data frames. |
When I first saw |
I'm going to close this issue. Kevin's additions (#177) get us consistent with base and get us multi-column sorting. |
order()
is no longer a Base function. It has been superseded bysortperm
. Also, we don't have something like R'sorder
that can order by multiple vectors. We useorder
in a few places, so how should we fix this? Options might include:order
withsortperm
.order
based onsortperm
. If so, how much ofsortperm
's flexibility should we pull in?sortperm
ororder
to handle multiple vector ordering.sortby
to cover multiple columns.I prefer having
order
(I don't like the namesortperm
).The text was updated successfully, but these errors were encountered: