Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with getproperty in @byrow #172

Closed
pdeffebach opened this issue Sep 26, 2020 · 0 comments · Fixed by #182
Closed

Fix bug with getproperty in @byrow #172

pdeffebach opened this issue Sep 26, 2020 · 0 comments · Fixed by #182

Comments

@pdeffebach
Copy link
Collaborator

julia> df = DataFrame(a = [1, 2], b = [3, 4]);

julia> @byrow df begin
       :a = mean(df.b)
       end
ERROR: syntax: invalid syntax "df.(##255[row])" around REPL[4]:2

This is a problem because QuoteNodes show up in getproperty calls.

julia> dump(:(d.x))
Expr
  head: Symbol .
  args: Array{Any}((2,))
    1: Symbol d
    2: QuoteNode
      value: Symbol x

This is a super easy fix, I think. replace_dotted already exists for other operations which cleans getproperty calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant