Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-factor code #242

Closed
pdeffebach opened this issue Apr 21, 2021 · 3 comments
Closed

re-factor code #242

pdeffebach opened this issue Apr 21, 2021 · 3 comments

Comments

@pdeffebach
Copy link
Collaborator

Now that the argument-handling code is so long, it's kind of hard to work with the big DataFramesMeta.jl file.

Is re-factoring into separate files always discouraged? Or is there a way to do it that preserves line-by-line commit histories.

cc @nalimilan

@bkamins
Copy link
Member

bkamins commented Apr 21, 2021

This is a good idea. I propose you to just split the code into files but without changing anything (then I can easily check that all is OK). And such a PR should contain only "code movement"

@pdeffebach
Copy link
Collaborator Author

done in #243

@bkamins
Copy link
Member

bkamins commented Apr 21, 2021

OK to close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants