Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress annotation of types #484

Merged
merged 2 commits into from
Aug 20, 2023
Merged

Suppress annotation of types #484

merged 2 commits into from
Aug 20, 2023

Conversation

timholy
Copy link
Member

@timholy timholy commented Aug 20, 2023

When a type like String appears explicitly in the source,
we don't need to annotate it as String::Type{String}.

Fixes #482
Fixes #465

When a type like `String` appears explicitly in the source,
we don't need to annotate it as `String::Type{String}`.

Fixes #482
Fixes #465
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2023

Codecov Report

Merging #484 (b2b61fb) into master (e7c424e) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #484   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           9       9           
  Lines        1511    1511           
======================================
  Misses       1511    1511           

@Zentrik
Copy link
Collaborator

Zentrik commented Aug 20, 2023

This should fix the tests, Zentrik@ff1de7c.

@timholy timholy merged commit 5734f8d into master Aug 20, 2023
14 checks passed
@timholy timholy deleted the teh/suppress_annotation branch August 20, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants