Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper detection can have false positives #553

Open
Keno opened this issue Nov 30, 2022 · 0 comments
Open

Wrapper detection can have false positives #553

Keno opened this issue Nov 30, 2022 · 0 comments

Comments

@Keno
Copy link
Contributor

Keno commented Nov 30, 2022

The code here tries to detect default argument wrappers by detecting patterns of use of the #self argument. However this is prone to false positive, because there are other kinds of methods that could have such patterns, e.g. Cassette-style context arguments. It would be better to adjust Base to add a new flag to methods that indicate that they're implicitly generated wrappers and set this flag from the frontend.
https://github.com/JuliaDebug/JuliaInterpreter.jl/blob/39d04c70762ab3dd4300be224eb12ab4a79cf608/src/commands.jl#LL233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant