Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing rule for factorial #344

Closed
mzgubic opened this issue Jan 13, 2021 · 1 comment · Fixed by #458
Closed

Missing rule for factorial #344

mzgubic opened this issue Jan 13, 2021 · 1 comment · Fixed by #458
Labels
good first issue Good for newcomers missing rule non-differentiable For issues/PRs relating to @non_differentiable

Comments

@mzgubic
Copy link
Member

mzgubic commented Jan 13, 2021

Should be added using @non_differentiable factorial(n::Integer)

@oxinabox
Copy link
Member

I considered for a bit that we could define it using the gamma function, tereating it as the embedding of an integer as a float.
But I think that is wrong, since if you perturb the input you will just get an error.
So it should be @non_differentiable
https://math.stackexchange.com/questions/300526/derivative-of-a-factorial

@oxinabox oxinabox added the non-differentiable For issues/PRs relating to @non_differentiable label Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers missing rule non-differentiable For issues/PRs relating to @non_differentiable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants