Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark allunique non_differentiable #597

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Mark allunique non_differentiable #597

merged 4 commits into from
Mar 9, 2022

Conversation

niklasschmitz
Copy link
Contributor

This PR marks the Bool-valued Base.allunique as non-differentiable.

mzgubic
mzgubic approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@mzgubic mzgubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, could you please bump the minor version?

@niklasschmitz
Copy link
Contributor Author

Thanks @mzgubic !

@mcabbott
Copy link
Member

mcabbott commented Mar 8, 2022

Maybe allequal too? with Compat 3.42.0

@mzgubic
Copy link
Member

mzgubic commented Mar 8, 2022

@niklasschmitz would you be willing to add what @mcabbott suggested?

@niklasschmitz
Copy link
Contributor Author

Sure, while we're at it :) added it, thanks @mcabbott for the pointer

@mcabbott mcabbott merged commit 9023d89 into JuliaDiff:main Mar 9, 2022
@niklasschmitz niklasschmitz deleted the nondiff-allunique branch March 9, 2022 06:44
@doddgray doddgray mentioned this pull request Mar 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzgubic mzgubic mzgubic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niklasschmitz @mcabbott @mzgubic