Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProjectTo(::AbstractSparseMatrix{Bool}) should be trivial #622

Open
mcabbott opened this issue May 29, 2023 · 0 comments
Open

ProjectTo(::AbstractSparseMatrix{Bool}) should be trivial #622

mcabbott opened this issue May 29, 2023 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed ProjectTo related to the projection functionality

Comments

@mcabbott
Copy link
Member

From FluxML/Zygote.jl#1428, these two should make the same ProjectTo{NoTangent}():

julia> using ChainRulesCore, SparseArrays

julia> ProjectTo(diagm([true, false]))
ProjectTo{NoTangent}()

julia> ProjectTo(spdiagm([true, false]))
ProjectTo{SparseMatrixCSC}(element = ProjectTo{NoTangent}(), axes = (Base.OneTo(2), Base.OneTo(2)), rowval = [1, 2], nzranges = UnitRange{Int64}[1:1, 2:2], colptr = [1, 2, 3])
@mcabbott mcabbott added bug Something isn't working help wanted Extra attention is needed ProjectTo related to the projection functionality labels May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed ProjectTo related to the projection functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcabbott