 DiffResults objects are not re-aliased properly

The DiffResults documentation clearly states that whenever a `DiffResult` object is used, it must be realiased at the end of the function call:

```julia
result = do_stuff!(result, args...)
```

See for instance the docstrings in https://juliadiff.org/DiffResults.jl/stable/#Mutating-a-DiffResult, or the issue [DiffResults#17](https://github.com/JuliaDiff/DiffResults.jl/issues/17)

This is not done by ReverseDiff, for instance here:

https://github.com/JuliaDiff/ReverseDiff.jl/blob/c982cde5494fc166965a9d04691f390d9e3073fd/src/api/gradients.jl#L21-L27

Am I right in deducing that it can lead to incorrectness?

	function gradient(f, input, cfg::GradientConfig = GradientConfig(input))
	tape = GradientTape(f, input, cfg)
	result = construct_result(input_hook(tape))
	seeded_reverse_pass!(result, tape)
	empty!(cfg.tape)
	return result
	end

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

DiffResults objects are not re-aliased properly #251

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

DiffResults objects are not re-aliased properly #251

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions