Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

derivative should lower order of the taylor series #268

Closed
Keno opened this issue Mar 26, 2021 · 4 comments · Fixed by #274
Closed

derivative should lower order of the taylor series #268

Keno opened this issue Mar 26, 2021 · 4 comments · Fixed by #274

Comments

@Keno
Copy link

Keno commented Mar 26, 2021 

julia> Taylor1(Float64, 5)
 1.0 t + 𝒪(t⁶)

julia> derivative(ans)
 1.0 + 𝒪(t⁶)

I'd have expected `𝒪(t⁵) terms for the derivative. As is, this implies that the t⁵ term is zero in the derivative, which is not the case.
@dpsanders
Copy link
Contributor

I agree that this seems incorrect.

@lbenet
Copy link
Member

lbenet commented Mar 26, 2021

Thanks for reporting this, @Keno.

I am actually addressing this, together with other cases (c.f. #230), but haven't had the time to complete it.

@lbenet
Copy link
Member

lbenet commented Apr 13, 2021

Addressed in #248

@lbenet lbenet linked a pull request Apr 13, 2021 that will close this issue
Fix order of linear_polynomial and add nonlinear_polynomial #274
Merged
@lbenet lbenet reopened this Apr 13, 2021
@lbenet lbenet mentioned this issue Apr 21, 2021
Merged
@lbenet
Copy link
Member

lbenet commented Apr 29, 2021

Closed by #248

@lbenet lbenet closed this as completed Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix order of linear_polynomial and add nonlinear_polynomial JuliaDiff/TaylorSeries.jl
3 participants
@dpsanders @Keno @lbenet