Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doctest fixing broken on Julia 1.5/nightly #1337

Closed
mortenpi opened this issue Jun 12, 2020 · 1 comment · Fixed by #1389
Closed

Doctest fixing broken on Julia 1.5/nightly #1337

mortenpi opened this issue Jun 12, 2020 · 1 comment · Fixed by #1389
Labels
Type: Bug Type: Upstream

Comments

@mortenpi
Copy link
Member 

julia> 1 + 2

julia> 3 + 4

becomes

julia> 1 + 2
3
3
3j3u3l3i3a3>3 333 3+3 343

Julia 1.4 and below are fine. This is causing the nightly failures.
@mortenpi mortenpi added this to the 0.25.0 milestone Jun 12, 2020
@mortenpi mortenpi modified the milestones: 0.25.0, 0.25.1 Jun 30, 2020
@mortenpi mortenpi removed this from the 0.25.1 milestone Jul 20, 2020
@mortenpi mortenpi mentioned this issue Jul 28, 2020
Closed
@mortenpi
Copy link
Member Author

mortenpi commented Aug 6, 2020

The specific doctest fails here:

Documenter.jl/src/DocTests.jl

Line 425 in b66e4ca

newcode *= replace(code[nextind(code, last(inputidx)):end], result.output => str, count = 1)

due to JuliaLang/julia#36953 (result.output happens to be an empty string in this test).

@mortenpi mortenpi mentioned this issue Aug 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Type: Upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Work around 1.5 & nightly test failures JuliaDocs/Documenter.jl
1 participant
@mortenpi