Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should be impossible to use two-variable measures with three-variable functions #324

Closed
kahaaga opened this issue Aug 31, 2023 · 0 comments · Fixed by #327
Closed

It should be impossible to use two-variable measures with three-variable functions #324

kahaaga opened this issue Aug 31, 2023 · 0 comments · Fixed by #327
Labels
bug Something isn't working
Milestone

Comments

@kahaaga
Copy link
Member

kahaaga commented Aug 31, 2023

It should not be possible to use a bivariate measure such as MIShannon with a three-or-more-input method like independence(indep_test, x, y, z). In these cases, only multi-variable measures should be accepted.

One possible solution is to encode the minimum number of input variables needed for each measure as a type argument, and error if not enough datasets are provided. EDIT: alternatively, and preferably, implement a minimum_input_args function for each of the measures that gets called before actually computing a measure.

@kahaaga kahaaga added the bug Something isn't working label Aug 31, 2023
@kahaaga kahaaga added this to the 2.9 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant