Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream dependants before 2.0 #107

Closed
3 tasks done
kahaaga opened this issue Sep 28, 2022 · 6 comments
Closed
3 tasks done

Upstream dependants before 2.0 #107

kahaaga opened this issue Sep 28, 2022 · 6 comments
Milestone

Comments

@kahaaga
Copy link
Member

kahaaga commented Sep 28, 2022

Upstream packages that need to be sure that work with Entropies.jl before tagging 2.0:

  • TransferEntropy.jl. Release 1.10 version locks Entropies.jl to ~ 1.2.
  • CausalityTools.jl. Release 1.10 version locks Entropies.jl to ~ 1.2.
  • ChaosTools.jl
@kahaaga kahaaga added this to the 2.0 milestone Oct 18, 2022
@Datseris Datseris changed the title Tag 2.0 Upstream dependants before 2.0 Oct 29, 2022
@Datseris
Copy link
Member

I've updated this comment to be just about upstream packages. GitHub milestones is a much better way to collect issues relevant with a new release

@kahaaga
Copy link
Member Author

kahaaga commented Nov 4, 2022

Update: CausalityTools packages now fixes the version of Entropies to 1.2, so we can safely release Entropies v2 without breaking anything there.

@Datseris
Copy link
Member

Datseris commented Nov 6, 2022

Oh, what I was talking about is to be sure we have tested 2.0 in downstream packages. I.e., each has a PR open that has been locally tested and shows that package's code has been updated to Entropies.jl 2.0 and indeed works fine.

@kahaaga
Copy link
Member Author

kahaaga commented Dec 27, 2022

@Datseris This is the only issue holding back 2.0.

Oh, what I was talking about is to be sure we have tested 2.0 in downstream packages. I.e., each has a PR open that has been locally tested and shows that package's code has been updated to Entropies.jl 2.0 and indeed works fine.

I don't see why that is necessary. I've pinned Entropies to v1.X in the latest CausalityTools 1.X. Any 2.X release of CausalityTools will strictly use Entropies 2.X. So there will be no conflict here. We should just release, and CausalityTools 2.0 (that uses Entropies v2) comes when I'm done with it.

What is the status for ChaosTools?

@Datseris
Copy link
Member

haven't had the time to work on it yet, but as long as I am sure the old API is deprecated and not broken, i am fine. I open a PR in a moment.

@Datseris
Copy link
Member

I made sure all deprecations work, so this can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants