Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify all basic types are concrete (and consider using sumtypes where possible) #95

Open
Krastanov opened this issue Aug 3, 2023 · 0 comments

Comments

@Krastanov
Copy link
Member

Julia is not fast when working with containers over abstract types. In particular, the heap and other fields in the Simulation type are currently abstractly typed or have abstract eltypes. We need a thorough cleanup here, to ensure we do not introduce unnecessary slowdowns.

The first step is to verify that Simulation and its fields are all fully concrete (recursively into the type of each field). The biggest offender is the heap.

The second step would be to verify this for the rest of the major types introduced in the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant