New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly implement in-place mutation #7

Open

tkf opened this issue Mar 4, 2021 · 0 comments

Member

tkf commented Mar 4, 2021

In-place update of the chunk/thunk input memory like this

FoldsDagger.jl/test/TestFoldsDagger/src/test_referenceables.jl

Lines 11 to 13 in d4e6002

    
           @floop DaggerEx() for x in referenceable(xs) 
        
               x[] += 1 
        
           end

is currently triggering an undefined behavior. We need JuliaParallel/Dagger.jl#186 for safely executing something like this.

jpsamaroo mentioned this issue

Use eager Dagger API #10

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment