-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CPUStatic
backend and implemented new initialparameters
interface.
#22
Conversation
…d as we most likely do not need this.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
===========================================
- Coverage 85.28% 42.96% -42.32%
===========================================
Files 22 25 +3
Lines 367 391 +24
===========================================
- Hits 313 168 -145
- Misses 54 223 +169 ☔ View full report in Codecov by Sentry. |
Should
My understanding was that this is considered a mild form of type piracy. |
Ok, I see I shouldn't have opened this pr that quickly ... It is true that in the
The only real case of type piracy is:
If the
If we opt for the latter the array type would look something like: struct NetworkStaticArray{T, AT <: MArray{T}} <: AbstractArray{T}
A::AT
end I think the second option is more reasonable. |
Defining a custom wrapper around |
Ok, then I'll just do |
Fixed missing end.
CPUStatic
was added as aBackend
.Further changes:
AbstractInitializer
was renamed toInitializer
.init
keyword was renamed toinitializer
.initialparameters
now always takes five input arguments:rng
,initializer
,model
,backend
,type
.This pr is breaking for
GeometricMachineLearning
andSymbolicNeuralNetworks
and should therefore be released asv0.5
.Fixes #18.
Fixes #19.