Remove redundant Const and inbounds macros #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for going through the codebase to remove the redundant macros - really appreciate it! Yes, I wanted a bit of time to discuss the interface with the community, add AK to the BuildKite CI, and include some proper Documenter.jl docs. I'm happy with the ideas from the Discourse and more confident in the library now that I know you tested it, looked around the codebase and felt it's useful - thanks! I'll register the package as soon as I can. |
|
I started the registration :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Constthat are not set on arrays (e.g. operators, functions, integers).@inboundsfrom_mapreduce_block!and_reduce_block!since they have kernel-levelinbounds=truespecified.Also unrelated to this, but are you planning on registering this package?
I wanted to use your sorting kernels for AMDGPU instead of ours, since they are ~4x faster: JuliaGPU/AMDGPU.jl#688