Atomix Extension #2549
Closed
Atomix Extension #2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I'm not convinced we want these extensions in the back-end repositories. I'd hope that the whole Atomix stack is a temporary thing (cc @vchuravy, hopefully we support plain LLVM atomics from Base at some point), so maybe it's better to keep these in the Atomix.jl repository? |
|
Closing in favour of JuliaConcurrent/Atomix.jl#42. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept for having the Atomix.jl backend as a CUDA.jl extension instead of a standalone package that lives in Atomix.jl.
Removes the need to add and import
AtomixCUDAwhich was created before package extensions were a thing.Added the tests to the main pipeline since Atomix is already a dependency and there are 3 tests so extra runtime should be minimal.
See JuliaConcurrent/Atomix.jl#39 (comment)