Skip to content
This repository has been archived by the owner on Mar 12, 2021. It is now read-only.

size(collect(F.Q)) != size(Matrix(F.Q)) when size(F, 1) > size(F, 2) for F :: CuQR #393

Closed
tkf opened this issue Aug 19, 2019 · 2 comments
Closed
Labels

Comments

@tkf
Copy link
Contributor

tkf commented Aug 19, 2019

julia> F = qr(CuArrays.ones(5, 1))
       @show size(F.Q) size(collect(F.Q)) size(Matrix(F.Q));
size(F.Q) = (5, 5)
size(collect(F.Q)) = (5, 5)
size(Matrix(F.Q)) = (5, 1)

My setup is described in #392.

@maleadt
Copy link
Member

maleadt commented Aug 20, 2019

This is true in Base as well, or am I misunderstanding something?

julia> F = qr(ones(5,1))
       @show size(F.Q) size(collect(F.Q)) size(Matrix(F.Q));
size(F.Q) = (5, 5)
size(collect(F.Q)) = (5, 5)
size(Matrix(F.Q)) = (5, 1)

@tkf
Copy link
Contributor Author

tkf commented Aug 20, 2019

Sorry, I didn't check it with the normal array. It turns out Matrix(Q) returns a thin matrix. JuliaLang/julia#27397

@tkf tkf closed this as completed Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants