-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Vulkan 1.3.240 #48
Conversation
It seems like there are a few issues with finding EDIT: I just realized it was already captured in #37. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
==========================================
- Coverage 34.42% 33.87% -0.56%
==========================================
Files 3 3
Lines 61 62 +1
==========================================
Hits 21 21
- Misses 40 41 +1
☔ View full report in Codecov by Sentry. |
Windows CI timed out during the installation of the SDK, it might be that the .exe requires interaction of some sort, though it used to be working fine before. |
It is getting stuck on the SDK download, let's prevent it from running a very long job for now
Alright, it got me some time (with a distraction under the form of https://github.com/serenity4/VulkanSpec.jl) but this PR is tested and ready now :) FYI, the Vulkan Video bindings are only for decode operations, which are no longer provisional, and encode operations (which are still provisional) are not included. Therefore it should be in line with our discussion in #43. I may update to v1.3.266 (or whatever will be the latest) soon after this PR, but if that is the case, it's anyways good to make incremental changes. |
(@Gnimuc if you have time to review, that would be fantastic, but otherwise it's alright - I am reasonably confident that I can merge this in the current state) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generator script looks good to me.
We may fix the Windows CI in the future though. (The last time I tried, it was still hard to debug the CI environment...) |
Thanks! Yep, eventually we should try to get Vulkan to work reliably on all platforms. I've been trying to put the validation layers in Yggdrasil, but it's not an easy one. |
This uses the latest Clang version, which showed no difference in the generated wrapper (tested for the Linux wrapper) before the update to 1.3.240.
I also removed a bunch of const annotations to facilitate tweaking the generator while prototyping.
TODO:
dev
ed specification for Clang (see Fix use of wrong variable inget_pkg_artifact_dir
JuliaInterop/Clang.jl#415)