Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it make sense to replace custom ColVecs, RowVecs code with ArraysOfArrays library #516

Closed
FelixBenning opened this issue Jun 2, 2023 · 4 comments

Comments

@FelixBenning
Copy link

see https://juliaarrays.github.io/ArraysOfArrays.jl/stable/. This appears to do the same thing. Just more general. This would allow more than matrices to be passed. I.e. you could have more than 1-dimensional input vectors.

@willtebbutt
Copy link
Member

It's an option. Taking a look at the code, the implementation looks reasonably complicated in comparison to our ColVecs / RowVecs, which makes me reluctant to adopt it.

That being said, there's nothing to stop you writing an extension to KernelFunctions which directly extends our kernels to interoperate nicely with those from ArrayOfArrays.jl, without us removing ColVecs / RowVecs.

@devmotion
Copy link
Member

IIRC the idea (a while back) was rather to use eachrow and eachcol since starting from Julia 1.9 (?) they return an array and not an iterator anymore: JuliaLang/julia#32310

@devmotion
Copy link
Member

See eg #394 (comment)

@FelixBenning
Copy link
Author

ah right eachrow and eachcol seems like the best solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants