Zygote update breaking CI

[glennmoy]

Zygot 0.6.5 released yesterday which I'm fairly certain is behind the failing CI

https://github.com/invenia/ParameterHandling.jl/runs/2189676220?check_suite_focus=true

CI passed the day before using 0.6.4

https://github.com/invenia/ParameterHandling.jl/runs/2180773450?check_suite_focus=true

More generally, there are no compat bounds in the test Project.toml

Zygote: Error During Test at /home/runner/work/ParameterHandling.jl/ParameterHandling.jl/test/parameters.jl:71
  Test threw exception
  Expression: only(pb(randn(3, 2))) isa Matrix{<:Real}
  ArgumentError: NamedTuple{(:U,),Tuple{Array{Float64,2}}} keys must be a subset of NamedTuple{(:V,),Tuple{Adjoint{Float64,Array{Float64,2}}}} keys
  Stacktrace:
   [1] #s77#84 at /home/runner/.julia/packages/Zygote/pM10l/src/lib/lib.jl:20 [inlined]
   [2] #s77#84(::Any, ::Any, ::Any) at ./none:0
   [3] (::Core.GeneratedFunctionStub)(::Any, ::Vararg{Any,N} where N) at ./boot.jl:543
   [4] accum(::NamedTuple{(:V,),Tuple{Adjoint{Float64,Array{Float64,2}}}}, ::Nothing, ::NamedTuple{(:U,),Tuple{Array{Float64,2}}}) at /home/runner/.julia/packages/Zygote/pM10l/src/lib/lib.jl:13
   [5] getindex at ./tuple.jl:24 [inlined]
   [6] (::typeof(∂(value)))(::Array{Float64,2}) at /home/runner/.julia/packages/Zygote/pM10l/src/compiler/interface2.jl:0
   [7] #3 at /home/runner/work/ParameterHandling.jl/ParameterHandling.jl/test/parameters.jl:70 [inlined]
   [8] (::typeof(∂(#3)))(::Array{Float64,2}) at /home/runner/.julia/packages/Zygote/pM10l/src/compiler/interface2.jl:0
   [9] (::Zygote.var"#41#42"{typeof(∂(#3))})(::Array{Float64,2}) at /home/runner/.julia/packages/Zygote/pM10l/src/compiler/interface.jl:41
   [10] top-level scope at /home/runner/work/ParameterHandling.jl/ParameterHandling.jl/test/parameters.jl:71
   [11] top-level scope at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.5/Test/src/Test.jl:1119
   [12] top-level scope at /home/runner/work/ParameterHandling.jl/ParameterHandling.jl/test/parameters.jl:70
   [13] top-level scope at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.5/Test/src/Test.jl:1119
   [14] top-level scope at /home/runner/work/ParameterHandling.jl/ParameterHandling.jl/test/parameters.jl:53
   [15] top-level scope at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.5/Test/src/Test.jl:1119
   [16] top-level scope at /home/runner/work/ParameterHandling.jl/ParameterHandling.jl/test/parameters.jl:8

[mzgubic]

It's FluxML/Zygote.jl#924.

Essentially, instead of silently returning a wrong result, it now errors. I think upgrading to ChainRulesCore 0.7.55 should solve it

[mzgubic]

Should I have bumped the compat for ChainRules there?

[willtebbutt]

It's actually great to have this error -- it means that changes to Zygote did what they were meant to do!

[mzgubic]

Oh sorry, no, this will be fixed by FluxML/Zygote.jl#926 which bumps the compat

[mzgubic]

Zygote 0.6.6 should solve this, just registered

[mzgubic]

FluxML/Zygote.jl#922