Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use robust orient2d predicate #14

Closed
mourner opened this issue May 8, 2023 · 4 comments
Closed

Use robust orient2d predicate #14

mourner opened this issue May 8, 2023 · 4 comments

Comments

@mourner
Copy link

mourner commented May 8, 2023

From the project's README:

In comparison, the Delaunator.jl package seeks to mirror the javascript Delauantor packages that give good enough triangulations for many pixel-level graphics applications and are fast for 2d problems, rather than those that might be suitable for those with computational geometry applications that need better guarantees (although we do hope to improve this in the future).

This behavior no longer mirrors Delaunator in JS — the latter is using robust orient2d predicate as of v4 (see mapbox/delaunator#68) to guarantee robust triangulation.

@dgleich
Copy link
Collaborator

dgleich commented Apr 16, 2024

Thanks for the comment and apologies about the confusion. The readme has been updated now. Hope we can get this improved to use the exact predicates sometime soon!

@asinghvi17
Copy link

https://github.com/vchuravy/AdaptivePredicates.jl/ covers the same surface as that JS library, so Delaunator could use that...

@dgleich
Copy link
Collaborator

dgleich commented May 6, 2024

Oh that's nice! I really would rather avoiding StaticArrays as a dependency -- and indeed, any dependencies at all :)

Let me take a look at what it'd take to modify it to get to a point where we could use this.

@DanielVandH
Copy link
Member

FYI @dgleich The rest of https://github.com/JuliaGeometry/AdaptivePredicates.jl has been ported over now in case you are interested on using it for incircle as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants