You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the issue! I don't think the solution is to restrict the more accurate branch to AbstractFloat, because then we would hit the less accurate branch whenever using wrappers of floating point numbers, e.g. those in ForwardDiff and ReverseDiff.
A better way is probably to specialize abs(::Quaternion{Num}) to hit the simpler version. On Julia v1.9, we can do this with a package extension (suggested in #123 (comment)). It makes more sense to include such an extension QuaternionsSymbolicsExt here than in Symbolics.
We used to be able to use
Symbolics.Num
in quaternions but #122 broke our workflow; see dionysos-dev/Dionysos.jl#211The issue is that
isinf
is not defined forNum
types defined in Symbolics. Maybe these could be done only forAbstractFloat
?cc @sethaxen
The text was updated successfully, but these errors were encountered: