Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependency on Quaternions.jl? #168

Closed
hyrodium opened this issue Oct 22, 2021 · 1 comment
Closed

Add dependency on Quaternions.jl? #168

hyrodium opened this issue Oct 22, 2021 · 1 comment
Labels
question

Comments

@hyrodium
Copy link
Collaborator

Rotations.jl used to depend on Quaternions.jl, but now there is no dependency on that package.
What was the reason for removing the dependency?

I thought it would be better to make it dependent on Quaternions.jl again for the following reasons:

  • We can reuse the method of Quaternion for UnitQuaternion <: Rotation
    • The definition will be like: struct UnitQuaternion{T} q::Quaternion{T} end
  • We can also reuse the method of Quaternion for SkewSymmetricQuaternion <: SkewSymmetric. (the naming of types are tentative)
  • We can add a method for convert(Quaternion, q) where q isa UnitQuaternion.
This was referenced Oct 28, 2021
Closed
Merged
@hyrodium
Copy link
Collaborator Author

hyrodium commented Nov 2, 2021

This will be fixed in #175, so I will close this issue.

@hyrodium hyrodium closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hyrodium