Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: newick format #15

Open
mkborregaard opened this issue Sep 11, 2018 · 5 comments
Open

feature request: newick format #15

mkborregaard opened this issue Sep 11, 2018 · 5 comments

Comments

@mkborregaard
Copy link

Do you, or would you, support reading graphs specified in a Newick format? https://en.wikipedia.org/wiki/Newick_format ? Perhaps in the context of MetaGraphs (as the Newick format contains some metadata)?

@sbromberger
Copy link
Contributor

We don't currently have this, but it looks interesting if you'd like to give it a shot. My advice is to create it as a standalone package - we're currently rethinking how we provide different file formats for graphs, and the current idea is to have several packages in a single repo (now that we can do this in Pkg3).

@mkborregaard
Copy link
Author

mkborregaard commented Sep 12, 2018

Oh 😞
Yeah I think having a standalone package just for a Newick parser is going rather overboard on the whole package-splitting thing. Especially given that you already have a dedicated GraphIO package 😂

I'll probably just put it in my downstream package that uses (/will most likely switch to using) MetaGraphs instead. There are already a number of packages with Newick parsers in them.

I just felt that, when using MetaGraphs, this functionality might nest nicely in the graph ecosystem.

@simonschoelly
Copy link
Member

If you import loadgraph, loadgraphs and savegraph from LightGraphs and implement them for the Newick format, it should be easy to add this to the LightGraphs ecosystem later.

@sbromberger
Copy link
Contributor

To be clear - the idea is to get rid of graphio as a package entirely and have each format be its own package but in a monorepo. That way, for example, if you need Graph6 you don’t need to have JLD installed.

@mkborregaard
Copy link
Author

Hm OK - I'll have a look at the approach suggest by @simonschoelly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants