-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
turn this into a monorepo #433
Comments
To be fair, I only added the Register action because a user asked for it repeatedly in an issue, but I don't actually use it 😇 |
I also havent completely figured out the testing mechanism cause both repos depend on one another for tests. At the moment I think you cannot test |
I did try but cannot manage to make it work https://github.com/CarloLucibello/GraphNeuralNetworks.jl/actions |
Yeah I had tried that a few times too and hit similar errors that I didn't understand, so I gave up |
For local development instead I found this comment pointing at a solution |
Right but my point about local testing is that people should be able to do using Pkg
Pkg.add("DifferentiationInterface")
Pkg.test("DifferentiationInterface") and it should just work. Right now it doesn't because my DifferentiationInterface |
Doesn't show up on https://pkgdocs.julialang.org/v1.10/toml-files/ |
I have figured out a better workflow for mutually dependent tests: |
closing as complited |
How did you solve the problem of the sibling packages needing to get the local versions of their friends during tests? Manual Pkg ops? |
yes. you can see that in the CI workflows |
We want to host in this repo 2 packages, GNNlib.jl (#432) and GraphNeuralNetworks.jl. In the future there will be another frontend like GraphNeuralNetworks.jl based on Lux.jl.
We want to host all of that into a single repo instead of multiple ones in order to facilitate development, since very likely a PR will often change both GNNlib.jl and the other repo.
Useful discussions on monorepos:
https://discourse.julialang.org/t/anything-to-be-wary-of-when-registering-a-subpackage/112459
https://discourse.julialang.org/t/how-beacon-packages-julia-code-in-a-monorepo/90822/9
JuliaLang/Pkg.jl#3263
Examples of monorepo:
https://github.com/tecosaur/DataToolkit.jl
https://github.com/MakieOrg/Makie.jl
https://github.com/ITensor/ITensors.jl
https://github.com/JuliaGeo/GeoInterface.jl
https://github.com/gdalle/DifferentiationInterface.jl
https://github.com/timholy/SnoopCompile.jl
The text was updated successfully, but these errors were encountered: