Fixing issues in Julia 1.11 and Julia 1.12 #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #422 +/- ##
==========================================
+ Coverage 90.45% 90.52% +0.07%
==========================================
Files 51 51
Lines 2796 2787 -9
==========================================
- Hits 2529 2523 -6
+ Misses 267 264 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Apparently, the pre-release CI is failing due to problems in MRIFiles. Check: MagneticResonanceImaging/MRIReco.jl#194. |
|
I am going to merge this and look into MRIReco's problem later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incorrect definition of the
getpropertyfunction forArray{Grad/RF/ADC}generated some weird errors. This PR fixes these issues.I also included
[workspace]'s to the Project.toml's. A feature that will be introduced in Julia 1.12 JuliaLang/Pkg.jl#3841. The cool thing is that our mono repo and test setups are greatly simplified. For the KomaMRICore tests, thetest_argsare justargs:and for CUDA (with CUDA added to the
v1.12environment)This one does not work yet, due to JuliaGPU/GPUCompiler.jl#593.The mono repo setup should be (I think?)
pkg> dev KomaMRIInstead of dev'ing all the environments for each sub-package and their corresponding test folders.