-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reading compound dataset with string contents errors #393
Comments
pfitzseb
changed the title
Compound dataset with string contents error
Reading compound dataset with string contents errors
Apr 27, 2017
@grahamrow could you please take a look at this? thanks |
Closed
Small file that reproduces this issue: |
Hmm, so is it not correctly identifying the membertype? |
This should be closed by #592. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This line errors when trying to read a compound dataset with string contents. Specifically,
unpad
is defined to take aString
and aCint
as inputs, whileread(io, UInt8, dsize)
is an Array ofUInt8
s andH5T_STR_NULLPAD
is aInt64
on my machine, whileCint
is an alias forInt32
.Wrapping the
read
in aString
constructor and relaxingunpad
s second argument's type restriction should work imho, but with my sample dataset I'm then getting aUnicodeError: invalid character index
. I'm not sure if that's specific to my dataset's layout though (theVector{UInt8}
read
spits out doesn't seem to be related to the string I'm expecting there at all, which might be a deeper issue).I'd be happy to investigate this more, but I think I'll need some guidance from someone more familiar with the codebase...
cc @grahamrow, because you implemented
read_row
in #365The text was updated successfully, but these errors were encountered: