Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Butterworth Kernel? #240

Open
babaq opened this issue Aug 3, 2021 · 3 comments
Open

Butterworth Kernel? #240

babaq opened this issue Aug 3, 2021 · 3 comments
Labels
good first issue Would make a good contribution from new contributors hacktoberfest help wanted

Comments

@babaq
Copy link

babaq commented Aug 3, 2021

Hi,

I can't find a butterworth kernel in the Images, and think would be a nice addition to the package.

The DSP.jl do have a Butterworth filter design, maybe could be used or looked up to generate the Factored Kernels.

Alex

@johnnychen94
Copy link
Member

johnnychen94 commented Aug 3, 2021

Yes, it's a good addition, can you open a PR to ImageFiltering? That's where most of the kernels lives.

@babaq
Copy link
Author

babaq commented Aug 4, 2021

I would like to contribute, but may not have the technical competence to implement the kernel, at least in a short period of time.

@johnnychen94
Copy link
Member

You can take a look at #147 as an example. Some source codes, docstrings, and test cases should be sufficient.

@johnnychen94 johnnychen94 transferred this issue from JuliaImages/Images.jl Nov 24, 2021
@johnnychen94 johnnychen94 added good first issue Would make a good contribution from new contributors hacktoberfest help wanted labels Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Would make a good contribution from new contributors hacktoberfest help wanted
Projects
None yet
Development

No branches or pull requests

2 participants