-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Project.toml version and fix a test #1063
Conversation
The broken tests might be due to some internal incompatibility to Colors 0.13 and ColorTypes 0.12 -- most packages in JuliaImages don't directly depend on them (but instead via ImageCore). We will need to find out what breaks the packages, fix that, and also add the missing tests to ImageCore to prevent further breakage. I'm not available this month, but I will do it in December if nobody does that before me. |
The issue is (and there may be more):
|
@johnnychen94 Wonder if you might have a bit of time to take a look to get the tests to pass and tag a new release. I've bumped a lot of the dependent packages, and hoping this is not a major issue to fix. |
The failing test is simply this and it is clearly an issue introduced in ColorTypes 0.12:
Something in
|
I'm disabling a couple of tests. I believe they actually pass erroneous inputs - and that there doesn't seem to be a fundamental issue in the dependent packages. I have marked these disabled tests as FIXME so that they can be found easily. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1063 +/- ##
==========================================
+ Coverage 83.17% 84.00% +0.82%
==========================================
Files 3 3
Lines 214 225 +11
==========================================
+ Hits 178 189 +11
Misses 36 36 ☔ View full report in Codecov by Sentry. |
It would be nice if @johnnychen94 and @timholy could take a look at the master. When this is registered, it should pull new versions of various packages in the Images ecosystem. |
@johnnychen94 @timholy There's a couple of tests failing here, which would be nice to resolve and then merge.