Use FDWatcher instead of _FDWatcher #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JamesWrigley Sorry, this is bumping an old PR, but would it be useful for you to have merge access for this package? |
|
Oh no worries, thanks for the bump 😅 But yeah, if that's ok with folks then it would be nice to have merge access :) I can't promise I'll be an active maintainer but I'll chip in where I can. |
|
@JamesWrigley Agree and Thank you! I invited you to be a member of JuliaInterop. I believe it should give you the ability to merge PRs here. |
This has a slightly more polished API.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #215 +/- ##
=======================================
Coverage 78.17% 78.17%
=======================================
Files 9 9
Lines 362 362
=======================================
Hits 283 283
Misses 79 79 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a slightly more polished API.