Generate complete bindings to libzmq #232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rather invasive change to use Clang.jl to generate bindings for everything in
zmq.h
, and then use those bindings in the rest of the library. My motivation for doing this is to make it easier to call the libzmq functions, both for us and for anyone who wants to use the low-level functions (e.g. for things we haven't explicitly wrapped). It's also nice to have the constants generated for us.It touches a lot of internals so this would definitely benefit from a review from someone more familiar with them 😅 In particular the code for
_Message
andMessage
, which took me a while to understand. I've written down my understanding of how that works in the comments ofgen.jl
. For the reviewers: I've tried to keep the commits atomic, so it might be easiest to review the commits one-by-one.I don't think it's quite ready to merge yet because I'd like to add some more docs, but it should be ready for review.CC @stevengj, @vtjnash