New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable documentation is out of date #249

Closed

JamesWrigley opened this issue Aug 12, 2024 · 1 comment

Labels

Member

JamesWrigley commented Aug 12, 2024

I just noticed that our stable docs still show v1.2.3 as the latest version 🤔 https://github.com/JuliaInterop/ZMQ.jl/actions/runs/10226928862/job/28302271549#step:6:101

Not sure why, the later tags are available but Documenter.jl seems to be ignoring them.

JamesWrigley added the bug label

Member Author

JamesWrigley commented Oct 8, 2024

Turns out that Documenter.jl looks at the GITHUB_REF environment variable to determine whether it's a release or dev build: https://github.com/JuliaDocs/Documenter.jl/blob/a0257f939c2be20c7a68ecc02c4ada8210f29495/src/deployconfig.jl#L319-L325

It needs to be triggered by a tag push for the variable to be set correctly, and for whatever reason it seems that that never occurred since v1.2.3 until I manually deleted/pushed the v1.3.0 tag just now: https://github.com/JuliaInterop/ZMQ.jl/actions?query=event%3Apush

Not sure why it was never triggered by TagBot pushing the tag, something to look into if it happens again.

JamesWrigley closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment