Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename reverse functions #41

Open
dpsanders opened this issue Mar 26, 2020 · 3 comments
Open

Rename reverse functions #41

dpsanders opened this issue Mar 26, 2020 · 3 comments

Comments

@dpsanders
Copy link
Member

We could rename the reverse functions to something like

rev(+) instead of plus_rev

@dpsanders
Copy link
Member Author

inv would be another option but then we would be committing type piracy when we defined inv(+).

@dpsanders
Copy link
Member Author

Another option would be a type like Reverse{+}. This is probably the best option.

cc @mewilhel

@mewilhel
Copy link
Contributor

I like the Reverse{+} option. I think it'll make for neater definitions e.g. function Reverse{+}(...) as opposed to function rev(::typeof(+), ...). That said both seem like good options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants