Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent, descriptive terminology for orthogonal factorizations #472

Closed
Sacha0 opened this issue Sep 26, 2017 · 6 comments
Closed

consistent, descriptive terminology for orthogonal factorizations #472

Sacha0 opened this issue Sep 26, 2017 · 6 comments

Comments

@Sacha0
Copy link
Member

Sacha0 commented Sep 26, 2017

Breadcrumb to JuliaLang/julia#23813 (comment): We should consider selecting broadly descriptive terminology for orthogonal factorizations (for example the adjective "truncated" rather than "thin" to describe the relevant type of QR/LQ/RQ/QL factorization), and then use that terminology consistently across all orthogonal factorizations (documentation, comments, function names and arguments, etc). Best!

@andreasnoack
Copy link
Member

Thanks. This is breaking so I've added it to the milestone. Good news is that it is easy to fix.

@Sacha0
Copy link
Member Author

Sacha0 commented Sep 26, 2017

Re. the milestone, this issue could be addressed after 1.0 if LinAlg moves out of base as anticipated? Best!

@andreasnoack
Copy link
Member

I'd be fine with either truncated or to "invert" the keyword such that you can ask for square.

@Sacha0
Copy link
Member Author

Sacha0 commented Sep 28, 2017

(The decision in triage was to leave this issue on the milestone under the assumption that the rename etc should require little time.)

@Sacha0
Copy link
Member Author

Sacha0 commented Oct 22, 2017

While preparing a pull request addressing this issue I realized that "truncated" has failings, particularly that "truncated [QR|RQ|LQ|QL]" can mean either "thin"/"reduced" or "truncated" in the SVD sense (which also exists for QR/RQ/LQ/QL). "reduced" isn't particularly descriptive. So @andreasnoack's suggestion of "inverting" the keyword to "square" now strikes me as wisest. Best!

@Sacha0
Copy link
Member Author

Sacha0 commented Oct 28, 2017

Closed by JuliaLang/julia#24279. Thanks all! :)

@Sacha0 Sacha0 closed this as completed Oct 28, 2017
@KristofferC KristofferC transferred this issue from JuliaLang/julia Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants