-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consistent, descriptive terminology for orthogonal factorizations #472
Comments
Thanks. This is breaking so I've added it to the milestone. Good news is that it is easy to fix. |
Re. the milestone, this issue could be addressed after 1.0 if |
I'd be fine with either |
(The decision in triage was to leave this issue on the milestone under the assumption that the rename etc should require little time.) |
While preparing a pull request addressing this issue I realized that "truncated" has failings, particularly that "truncated [QR|RQ|LQ|QL]" can mean either "thin"/"reduced" or "truncated" in the SVD sense (which also exists for QR/RQ/LQ/QL). "reduced" isn't particularly descriptive. So |
Closed by JuliaLang/julia#24279. Thanks all! :) |
Breadcrumb to JuliaLang/julia#23813 (comment): We should consider selecting broadly descriptive terminology for orthogonal factorizations (for example the adjective "truncated" rather than "thin" to describe the relevant type of QR/LQ/RQ/QL factorization), and then use that terminology consistently across all orthogonal factorizations (documentation, comments, function names and arguments, etc). Best!
The text was updated successfully, but these errors were encountered: