-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
normalize(a) for multidimensional arrays #688
Comments
I suspect that this is a relic of the days prior to JuliaLang/julia#27401 when Should be an easy change to this code:
A PR would be welcome and should be easy even for newcomers. |
* Add support normalize multi dim arrays * remove trailing whitespace from test * var name v => a for inner function * Update normalize tests Case for OffsetArray where A[1] would fail but first(A) would not. Also some more test cases to compare with the vector case * add NEWS item * make docstring example w/ array more julia-thonic * reduce redundant test cases * add test for normalize on Int64 array * add 0 1 and high dim test cases
Seems like this was closed in 8f9dd5d. |
* Add support normalize multi dim arrays * remove trailing whitespace from test * var name v => a for inner function * Update normalize tests Case for OffsetArray where A[1] would fail but first(A) would not. Also some more test cases to compare with the vector case * add NEWS item * make docstring example w/ array more julia-thonic * reduce redundant test cases * add test for normalize on Int64 array * add 0 1 and high dim test cases
Currently
norm
is definined for arbitrary dimensionArrays
, whilenormalize
only works on vectors,I find this odd and it bites me every now and then. For instance I often want to normalize before plotting.
Can we have
normalize/normalize!
methods that works onAbstractArray
(or ducktyped method onAny
)?The text was updated successfully, but these errors were encountered: