Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an already-installed General registry via pkgserver shows no output, where clones do #3747

Closed
IanButterworth opened this issue Jan 5, 2024 · 1 comment · Fixed by #3979

Comments

@IanButterworth
Copy link
Member

This does update General, as a progress meter shows up but it disappears and doesn't let you know it already exists like a clone does.

It's quite confusing on CI because this is all you see.

$ julia -e 'using Pkg; Pkg.Registry.add([RegistrySpec(name="General"), RegistrySpec(url="https://github.com/HolyLab/HolyLabRegistry")]);'
     Cloning registry from "https://github.com/HolyLab/HolyLabRegistry"
Registry `HolyLabRegistry` already exists in `~/.julia/registries/HolyLabRegistry`.
@omus
Copy link
Member

omus commented Jan 9, 2024

Something else that's weird about this is that it appears we clone the entire registry first before we check if it's already present. Seems like we could see a performance improvement if we checked for the registries existence first and if it exists refresh it?

Update: Made a separate issue for this: #3753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants