You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The credentials argument of the GitTools.fetch function has two uses in that function as far as I can tell:
It gets populated with a default, if its nothing.
It gets shredded.
This sounds to me like it could be removed without changing any functionality.
I am willing to submit a pull request for that but I wanted to ask something first.
Is there a reason for the credential argument existing?
Was this code just copied over from the clone method above and never adjusted for the vestigial credentials argument?
Or should the credentials argument be passed on to the LibGit2.fetch method? As far as I can tell the argument would be supported by LibGit2.
The text was updated successfully, but these errors were encountered:
https://github.com/JuliaLang/Pkg.jl/blob/a2b8729eabb33c4773bf21f0d7a0ccad8ce76457/src/GitTools.jl#162C1-L164C10
The credentials argument of the
GitTools.fetch
function has two uses in that function as far as I can tell:This sounds to me like it could be removed without changing any functionality.
I am willing to submit a pull request for that but I wanted to ask something first.
Is there a reason for the credential argument existing?
Was this code just copied over from the clone method above and never adjusted for the vestigial credentials argument?
Or should the credentials argument be passed on to the
LibGit2.fetch
method? As far as I can tell the argument would be supported by LibGit2.The text was updated successfully, but these errors were encountered: