Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused credential argument in GitTools.fetch #3833

Open
lklein-btig opened this issue Mar 7, 2024 · 0 comments
Open

Unused credential argument in GitTools.fetch #3833

lklein-btig opened this issue Mar 7, 2024 · 0 comments

Comments

@lklein-btig
Copy link

lklein-btig commented Mar 7, 2024

https://github.com/JuliaLang/Pkg.jl/blob/a2b8729eabb33c4773bf21f0d7a0ccad8ce76457/src/GitTools.jl#162C1-L164C10

The credentials argument of the GitTools.fetch function has two uses in that function as far as I can tell:

  1. It gets populated with a default, if its nothing.
  2. It gets shredded.

This sounds to me like it could be removed without changing any functionality.
I am willing to submit a pull request for that but I wanted to ask something first.
Is there a reason for the credential argument existing?
Was this code just copied over from the clone method above and never adjusted for the vestigial credentials argument?
Or should the credentials argument be passed on to the LibGit2.fetch method? As far as I can tell the argument would be supported by LibGit2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant