Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Woodbury special matrix type #10024

Merged
merged 3 commits into from
Feb 2, 2015
Merged

remove Woodbury special matrix type #10024

merged 3 commits into from
Feb 2, 2015

Conversation

jakebolewski
Copy link
Member

This is not used anywhere in the Linalg module or in Base and the number of methods it supports a fairly limited compared to the other special matrix types. Now would be a good time to extract it out into an external package. See JuliaLang/LinearAlgebra.jl#33

cc @timholy, @jiahao

@timholy
Copy link
Member

timholy commented Feb 2, 2015

Seems reasonable to me.

@jakebolewski
Copy link
Member Author

Where would you like it to go? I can submit a PR.

@jiahao
Copy link
Member

jiahao commented Feb 2, 2015

I think @andreasnoack's LinearAlgebra.jl would be a good home for the Woodbury code.

@ViralBShah
Copy link
Member

+1 I have been wanting to do this for a while.

@timholy
Copy link
Member

timholy commented Feb 2, 2015

@timholy
Copy link
Member

timholy commented Feb 2, 2015

I can move it to LinearAlgebra.jl if you want. I just wanted to rescue it before it disappeared.

@jakebolewski
Copy link
Member Author

With git nothing disappears :-)

@timholy
Copy link
Member

timholy commented Feb 2, 2015

Yes, but the number of keystrokes increases :-).

@andreasnoack
Copy link
Member

I'd be happy to host it in LinearAlgebra.jl, but my package is not ready for publication yet so in the meantime it is probably good to have in a separate package. Then we can consolidate later.

@jiahao
Copy link
Member

jiahao commented Feb 2, 2015

I'll let @andreasnoack comment first, but the idea for LinearAlgebra.jl was to house experimental and more esoteric linear algebra functionality that didn't really belong to Base.

@timholy
Copy link
Member

timholy commented Feb 2, 2015

Just create an issue over at WoodburyMatrices when you want me to do something.

jakebolewski added a commit that referenced this pull request Feb 2, 2015
remove Woodbury special matrix type
@jakebolewski jakebolewski merged commit 1814bba into master Feb 2, 2015
@jakebolewski jakebolewski deleted the jcb/rmwoodbury branch February 2, 2015 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants