Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: change == to === where possible #10251

Closed
StefanKarpinski opened this issue Feb 19, 2015 · 4 comments
Closed

tests: change == to === where possible #10251

StefanKarpinski opened this issue Feb 19, 2015 · 4 comments
Labels
good first issue Indicates a good issue for first-time contributors to Julia test This change adds or pertains to unit tests

Comments

@StefanKarpinski
Copy link
Member

See discussion here: 2af73dd. Where possible, we should test the identify of the return value, not just its value. This would catch more changes that could possibly break packages and other external code.
@StefanKarpinski StefanKarpinski added help wanted Indicates that a maintainer wants help on an issue or pull request test This change adds or pertains to unit tests labels Feb 19, 2015
StefanKarpinski referenced this issue Feb 19, 2015
@samoconnor
Refinement per @vtjnash comments.
2af73dd 
Make uv_write() a function (was a macro) and do c_free in "finally" clause.

Explicit null-termination in jl_safe_printf() to allow for win32's
non-posix vsnprintf behaviour. See also #9624.

Use jl_safe_printf() in profile thread.

Send help message to jl_printf(JL_STDOUT,)  was stderr.
@sbromberger
Copy link
Contributor

This should also probably be referenced in/by #9493 as well.

@catawbasam
Copy link
Contributor

Thoughts re #10261? (testing type / identity of mutables)

@ihnorton ihnorton added good first issue Indicates a good issue for first-time contributors to Julia and removed help wanted Indicates that a maintainer wants help on an issue or pull request labels May 8, 2015
@musm
Copy link
Contributor

musm commented Feb 7, 2019

Is this something that can be closed now?

@vtjnash vtjnash closed this as completed Feb 7, 2019
@vtjnash
Copy link
Member

vtjnash commented Feb 7, 2019

Yep, don't think there's anything actionable here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Indicates a good issue for first-time contributors to Julia test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@StefanKarpinski @ihnorton @vtjnash @sbromberger @catawbasam @musm