Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji REPL completion #10709

Merged
merged 1 commit into from
Apr 1, 2015
Merged

Emoji REPL completion #10709

merged 1 commit into from
Apr 1, 2015

Conversation

jakebolewski
Copy link
Member

screen shot 2015-04-01 at 12 48 12 am

screen shot 2015-04-01 at 12 46 58 am

To quote @jiahao:

These are the voyages of the flagship Julia. Its five-year mission: to explore strange new symbols, to seek out new codepoints and new characters, to boldly go where no language has gone before.

Happy April 1st

@simonbyrne
Copy link
Contributor

Should we also make 💯 a MathConst?

@sbromberger
Copy link
Contributor

As long as we're allowed to propose PRs that assign math constants to these new symbols, I'm all in favor. 👍

ETA: damnit. @simonbyrne was quicker on the keyboard.

@sbromberger
Copy link
Contributor

although 👍 might be more appropriate as an incrementer function :)

@jakebolewski
Copy link
Member Author

julia> 💯
💯 = 100.0...

julia> fill(💯, (5,5))
5x5 Array{MathConst{:💯},2}:
 💯 = 100.0...  💯 = 100.0...  💯 = 100.0...  💯 = 100.0...  💯 = 100.0...
 💯 = 100.0...  💯 = 100.0...  💯 = 100.0...  💯 = 100.0...  💯 = 100.0...
 💯 = 100.0...  💯 = 100.0...  💯 = 100.0...  💯 = 100.0...  💯 = 100.0...
 💯 = 100.0...  💯 = 100.0...  💯 = 100.0...  💯 = 100.0...  💯 = 100.0...
 💯 = 100.0...  💯 = 100.0...  💯 = 100.0...  💯 = 100.0...  💯 = 100.0...

@timholy
Copy link
Member

timholy commented Apr 1, 2015

Love it!

@sbromberger
Copy link
Contributor

Defining 👍 as a function appears to hang the REPL :(

@simonbyrne
Copy link
Contributor

We actually probably don't want 💯 as a MathConst, as all the inequality functions assume that MathConsts are irrational. We could have const 💯 =100 though.

@jakebolewski
Copy link
Member Author

Obviously this PR is just for fun, but it is entertaining enough that it might be worthwhile to have it as an easter-egg.

@pao
Copy link
Member

pao commented Apr 1, 2015

Is there a way to add completions at run-time so that using EmojiCompletions could be a thing?

@jakebolewski
Copy link
Member Author

There might be a way, but the latex substitution claims the convenient \<tab> idiom.

jakebolewski added a commit that referenced this pull request Apr 1, 2015
@jakebolewski jakebolewski merged commit ad6a3ea into master Apr 1, 2015
@jakebolewski
Copy link
Member Author

@Keno likes emojis.

@jakebolewski jakebolewski deleted the jcb/emoji branch April 1, 2015 23:21
@sbromberger
Copy link
Contributor

man, I just did a build this morning. Now I get to rebuild. Thanks. :)

@hayd
Copy link
Member

hayd commented Apr 2, 2015

👍 Emojis are clearly the future.


Is the following a problem with my terminal or julia?

If you type, 👍 123 (without space), it looks fine, once you press return the 1 overlaps the 👍.

julia> 👍123<ENTER>

Perhaps this because the length(":+1:") == 1? (Should it be 2?)

I also see this if I tab complete two 👍👍 in a row.

@jiahao
Copy link
Member

jiahao commented Apr 2, 2015

@hayd you've run into the notorious pizza/koala bug. #3721

@pao
Copy link
Member

pao commented Apr 2, 2015

There might be a way, but the latex substitution claims the convenient idiom.

Ah, I see. I was hoping that those were themselves runtime extensible. But definitely in the "nice-to-have" category.

jakebolewski added a commit that referenced this pull request Apr 3, 2015
@goretkin
Copy link
Contributor

Today's XKCD's alt text: http://xkcd.com/1513/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants