Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimising repeated calls to log #10922

Closed
js947 opened this issue Apr 21, 2015 · 4 comments
Closed

Optimising repeated calls to log #10922

js947 opened this issue Apr 21, 2015 · 4 comments
Labels
compiler:codegen Generation of LLVM IR and native code help wanted Indicates that a maintainer wants help on an issue or pull request performance Must go faster
Milestone
0.5.x

Comments

@js947
Copy link

js947 commented Apr 21, 2015

with

f(x) = log(x) + log(x)
@code_native f(1.0)

it seems that log(%0) is being called twice.
@simonster
Copy link
Member

Related: #414, #9942

@ihnorton ihnorton added performance Must go faster compiler:codegen Generation of LLVM IR and native code labels Apr 21, 2015
@simonbyrne simonbyrne mentioned this issue May 22, 2015
Closed
@StefanKarpinski StefanKarpinski added this to the 0.5.x milestone Sep 13, 2016
@vtjnash
Copy link
Member

vtjnash commented Sep 15, 2016

@StefanKarpinski this is a really gratuitous feature (fairly expensive for the compiler and but generally something that the author could have avoided in the first place), why is it point-release critical?

@StefanKarpinski
Copy link
Member

It's not – it's an optimization which means that it could be done for 0.5.x. If it doesn't that's also fine.

@StefanKarpinski StefanKarpinski added help wanted Indicates that a maintainer wants help on an issue or pull request and removed help wanted Indicates that a maintainer wants help on an issue or pull request labels Oct 27, 2016
@KristofferC
Copy link
Member

This looks like a pure dup of #9942.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler:codegen Generation of LLVM IR and native code help wanted Indicates that a maintainer wants help on an issue or pull request performance Must go faster
Projects
None yet
Milestone
0.5.x
Development

No branches or pull requests
6 participants
@StefanKarpinski @ihnorton @vtjnash @simonster @KristofferC @js947