Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge Union and UnionType; allow writing union types with Union{ } #11432

Merged
merged 1 commit into from
Jun 15, 2015
Merged

merge Union and UnionType; allow writing union types with Union{ } #11432

merged 1 commit into from
Jun 15, 2015

Conversation

JeffBezanson
Copy link
Member

No description provided.

@tkelman
Copy link
Contributor

tkelman commented May 25, 2015

Looks like the right way to go and shouldn't break anything in packages due to the fallback definition, but it's freezing while building inference on Win64 which I can reproduce locally. Ideas?

@tkelman
Copy link
Contributor

tkelman commented May 25, 2015

Very much worth noting: the freeze does not occur with LLVM 3.6.0.

@JeffBezanson
Copy link
Member Author

Looks like there was a segfault due to not being able to find append_any in the Inference module from jl_f_apply during the first bootstrap stage.

@JeffBezanson JeffBezanson force-pushed the jb/curlyunion branch 2 times, most recently from 1dd6307 to 8e99085 Compare May 26, 2015 21:12
@JeffBezanson JeffBezanson mentioned this pull request May 27, 2015
Merged
@JeffBezanson JeffBezanson force-pushed the jb/curlyunion branch 2 times, most recently from 4721dc1 to 0b0085a Compare May 29, 2015 17:47
@JeffBezanson JeffBezanson force-pushed the jb/curlyunion branch 4 times, most recently from 73f7c64 to cf39071 Compare June 14, 2015 18:56
@tkelman
Copy link
Contributor

tkelman commented Jun 14, 2015

repr(Nullable()) test needs to be updated

@JeffBezanson
Copy link
Member Author

Yep, working on it.

JeffBezanson added a commit that referenced this pull request Jun 15, 2015
@JeffBezanson
Merge pull request #11432 from JuliaLang/jb/curlyunion
126763e 
merge Union and UnionType; allow writing union types with `Union{ }`
@JeffBezanson JeffBezanson merged commit 126763e into master Jun 15, 2015
@JeffBezanson JeffBezanson deleted the jb/curlyunion branch June 17, 2015 18:34
ScottPJones added a commit to ScottPJones/julia that referenced this pull request Jun 19, 2015
@ScottPJones
Add news about JuliaLang#11432, curly braces for type Unions
c2b6a46
JeffBezanson added a commit that referenced this pull request Jun 19, 2015
@JeffBezanson
Merge pull request #11762 from ScottPJones/spj/unionnews
2573f5a 
Add news about #11432, curly braces for type Unions
fcard pushed a commit to fcard/julia that referenced this pull request Jul 8, 2015
@ScottPJones @fcard
Add news about JuliaLang#11432, curly braces for type Unions
336eeed
@yuyichao yuyichao mentioned this pull request Jul 12, 2015
Closed
stevengj added a commit to stevengj/julia that referenced this pull request Aug 13, 2015
@stevengj
convert more Union(...) to Union{...} instances that escaped JuliaLan…
4b0fd13 
…g#11432
@stevengj stevengj mentioned this pull request Aug 13, 2015
Merged
stevengj added a commit to stevengj/julia that referenced this pull request Aug 14, 2015
@stevengj
convert more Union(...) to Union{...} instances that escaped JuliaLan…
c3d3107 
…g#11432
vtjnash added a commit that referenced this pull request Aug 14, 2015
@vtjnash
Merge pull request #12606 from stevengj/Union_brace
e37f632 
convert more Union(...) to Union{...} instances that escaped #11432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffBezanson @tkelman