Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate sprandbool #11688

Closed
ViralBShah opened this issue Jun 12, 2015 · 4 comments · Fixed by #16098
Closed

Deprecate sprandbool #11688

ViralBShah opened this issue Jun 12, 2015 · 4 comments · Fixed by #16098
Labels
sparse Sparse arrays
Milestone

Comments

@ViralBShah
Copy link
Member

Just like we deprecated randbool, we should probably deprecate sprandbool. While doing so, it would be nice to extend the sprand API to generate sparse matrices with all the element types the RNG supports, similar to the dense rand.

@ViralBShah ViralBShah added system:MS-DOS See the Windows label sparse Sparse arrays and removed system:MS-DOS See the Windows label labels Jun 12, 2015
@tkelman
Copy link
Contributor

tkelman commented Jun 12, 2015

related - #11557

@jakebolewski jakebolewski added this to the 0.5 milestone Aug 13, 2015
@tkelman tkelman self-assigned this Apr 21, 2016
@ViralBShah
Copy link
Member Author

@KristofferC Would it be possible for you to address this in your recently opened sprand PR?

@KristofferC
Copy link
Member

I would rather do that in a new PR. Easier in my opinion if the PRs are small and focus on one thing.

@ViralBShah
Copy link
Member Author

Fair enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sparse Sparse arrays
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants