RemoteRefs refer to any type of AbstractChannel #12385
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR:
RemoteRef
s refer to anAbstractChannel
AbstractChannel
, implementstake!
,fetch
,put!
,isready
andwait
RemoteRef(f::Function, pid=myid())
wheref()
must return anAbstractChannel
, is used to construct a remote channel on workerpid
.RemoteRef
constructors create a remoteChannel{Any}(1)
which mimics the current behavior.The larger and deeper issue of redoing distributed gc in #12042 can be deferred to 0.5
We don't break any existing code and this is a minimal change that enables us to have remote channels of specified type and length in 0.4 itself. And more importantly unifies RemoteRefs and Channels.
cc @JeffBezanson, @jakebolewski , @ViralBShah, @malmaud