accept ∈ as a synonym for 'in' inside for loops and comprehensions #13824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
added
needs decision
stevengj
force-pushed
the
forin
branch
4 times, most recently
from
ecebf4e to
b205f2a
Compare
|
Thanks. I saw that you change the example in the docs from "in" to "∈", I would keep the "in" for the moment as it is at this moment trivially more widely used as "∈". |
|
The docs have examples of both, as it should if both are supported. However, this PR is pending a conclusion to the discussion in #8487 of whether we want this syntax. |
|
Sure, why not. Let's rebase and merge this. |
|
Rebased. |
jakebolewski
added a commit
that referenced
this pull request
Dec 8, 2015
accept ∈ as a synonym for 'in' inside for loops and comprehensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #8487, it's a bit odd and confusing that we allow
x ∈ Xas synonym forx in Xcomparisons, but we don't allowfor x ∈ Xas a synonym forfor x in X.This patch changes the parser to allow
∈as a synonym forininforloops and comprehensions.(This should be backwards compatible: even existing code that works with ASTs is not affected, because both
for x ∈ Xandfor x in Xare parsed asfor x = X.)