-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIT-licensed sparse() parent method and expert driver, take two #15242
Conversation
@@ -91,6 +91,8 @@ Library improvements | |||
* Rank one update and downdate functions, `lowrankupdate`, `lowrankupdate!`, `lowrankdowndate`, | |||
and `lowrankdowndate!`, for dense Cholesky factorizations ([#14243],[#14424]) | |||
|
|||
* All `sparse` methods now retain provided numerical zeros as structural nonzeros. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mention SparseArrays.dropzeros!
as the way to get rid of them when the user would like to do so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds wise. In fact, given dropzeros!
should become increasingly important / regularly used with the shift to retaining numerical zeros by default, perhaps dropzeros!
should now be exported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for exporting dropzeros!
and making other operations retain zeros (including the sparse
function).
I added lines to this effect to Assuming exporting |
Maybe do the export separately, I'd rather get this merged. Hopefully @jrevels and others will figure out the right way to standardize running package-based benchmarks over time. When it does get exported, it should also be added to the docs and probably tested a bit more extensively. |
Sounds great. Let me know if any other touch-ups are in order here. Thanks again, and best! |
apt-get travis issue addressed by #15249, restarted
edit: since that was fixed by a .travis.yml change, it may need a rebase to actually apply on the PR build. This passes on win32 so I don't see why it wouldn't pass on linux 32 bit. |
MIT-licensed sparse() parent method and expert driver, take two
@tkelman Much thanks for the thorough review! |
See #14798 (the original pull request) for discussion. Apologies for the close/reopen-glitch!